Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cfi-icall breakage #1

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Fix cfi-icall breakage #1

merged 2 commits into from
Nov 28, 2017

Conversation

lattera
Copy link
Contributor

@lattera lattera commented Nov 23, 2017

Signed-off-by: Shawn Webb shawn.webb@hardenedbsd.org

Signed-off-by:	Shawn Webb <shawn.webb@hardenedbsd.org>
@gwsw
Copy link
Owner

gwsw commented Nov 24, 2017

Thanks for the patch Shawn. One question: I understand the change to add VOID_PARAM to the getccu prototype, but was there a reason you changed the four calls through the function pointers from the (*gr_getc)() style to gr_getc()? AFAIK they are equivalent but the former is the style used elsewhere in less so I'd prefer to keep it consistent.

@lattera
Copy link
Contributor Author

lattera commented Nov 24, 2017

I can remove that. It was a stylistic thing that was bugging me while I was debugging the issue. Consider it leftover cruft.

Would you like me to update this PR to undo the stylistic changes? I'd be more than happy to do so.

@gwsw
Copy link
Owner

gwsw commented Nov 27, 2017

Yes, if you could trim it down to the necessary change, I'd appreciate it.

Signed-off-by:	Shawn Webb <shawn.webb@hardenedbsd.org>
@lattera
Copy link
Contributor Author

lattera commented Nov 27, 2017

Done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants