Notify scheduler if thread in rcving has pending events
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is required as current state of thread is not changed when a Sender sends notification to a receiving end-point it has attached to. More info in issue gwsystems#198
gparmer
reviewed
Sep 24, 2016
| @@ -67,7 +67,7 @@ scheduler(void) | |||
| VM_BUDGET_FIXED, VM_PRIO_FIXED, TCAP_DELEG_YIELD)) assert(0); | |||
| } | |||
|
|
|||
| while (cos_sched_rcv(BOOT_CAPTBL_SELF_INITRCV_BASE, &tid, &rcving, &cycles)) ; | |||
| while (cos_sched_rcv(BOOT_CAPTBL_SELF_INITRCV_BASE, &tid, &rcving, &vm_pending, &cycles)) ; | |||
There was a problem hiding this comment.
OK, now I'm confused why we would have both rcving and vm_pending. Shouldn't the pending just be taken into account in the kernel when returning the rcving variable? Why is this being made more complicated.
The API (as we discussed) is "set this variable to 1 if I can't effectively switch to the thread, set it to 0 if it is runnable". So why now two variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR
cos_sched_rcvto receive notifications and if the scheduling event haspendingevents, a temporary change, so that scheduler gets to decide whether to run the thread that isrcving. More info in #198Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship: