Make Validation sample compile in strict mode (failOnError)

Change-Id: Ieeb310ff317cc03eb004ea07d37e9855ccbfc450
gwtproject · Jan 24, 2016 · 0e6650a · 0e6650a
1 parent a0de97b
commit 0e6650a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/samples/validation/pom.xml b/samples/validation/pom.xml
@@ -133,7 +133,7 @@
         <configuration>
           <moduleName>com.google.gwt.sample.validation.Validation</moduleName>
           <moduleShortName>Validation</moduleShortName>
-          <failOnError>false</failOnError><!-- There are deliberate server-only code in ServerValidator that would fail the build -->
+          <failOnError>true</failOnError>
           <!-- Compiler configuration -->
           <compilerArgs>
             <!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->

diff --git a/...e/validation/shared/ServerConstraint.java → ...e/validation/server/ServerConstraint.java b/...e/validation/shared/ServerConstraint.java → ...e/validation/server/ServerConstraint.java
@@ -13,7 +13,7 @@
  * License for the specific language governing permissions and limitations under
  * the License.
  */
-package com.google.gwt.sample.validation.shared;
+package com.google.gwt.sample.validation.server;
 
 import static java.lang.annotation.ElementType.ANNOTATION_TYPE;
 import static java.lang.annotation.ElementType.CONSTRUCTOR;
@@ -44,4 +44,4 @@
   Class<?>[] groups() default {};
 
   Class<? extends Payload>[] payload() default {};
-}
+}
diff --git a/...le/validation/shared/ServerValidator.java → ...le/validation/server/ServerValidator.java b/...le/validation/shared/ServerValidator.java → ...le/validation/server/ServerValidator.java
@@ -13,7 +13,9 @@
  * License for the specific language governing permissions and limitations under
  * the License.
  */
-package com.google.gwt.sample.validation.shared;
+package com.google.gwt.sample.validation.server;
+
+import com.google.gwt.sample.validation.shared.Person;
 
 import java.lang.reflect.Method;
 

diff --git a/samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Person.java b/samples/validation/src/main/java/com/google/gwt/sample/validation/shared/Person.java
@@ -15,6 +15,8 @@
  */
 package com.google.gwt.sample.validation.shared;
 
+import com.google.gwt.sample.validation.server.ServerConstraint;
+
 import com.google.gwt.user.client.rpc.IsSerializable;
 
 import java.util.Map;