Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clinit no optimized for java.lang.String (regression) #9387

Closed
gkdn opened this issue Aug 4, 2016 · 1 comment
Closed

clinit no optimized for java.lang.String (regression) #9387

gkdn opened this issue Aug 4, 2016 · 1 comment
Assignees
@rluble
Milestone
2.8

Comments

@gkdn
Copy link
Contributor

gkdn commented Aug 4, 2016

The GWT generated code has String clinit all over the place as it is no longer removed for some reason.
@gkdn gkdn added this to the 2.8 milestone Aug 4, 2016
@gkdn gkdn changed the title clinit no longer optimized for java.lang.String in trunk clinit no optimized for java.lang.String (regression) Aug 4, 2016
@gkdn gkdn mentioned this issue Aug 4, 2016
Closed
@rluble
Copy link
Contributor

rluble commented Aug 4, 2016

code review at https://gwt-review.googlesource.com/#/c/15510

@rluble rluble closed this as completed Aug 4, 2016
@rluble rluble mentioned this issue Aug 5, 2016
Closed
vasvir pushed a commit to BiovistaInc/gwt that referenced this issue Aug 10, 2016
@rluble
DeadCodeElimination was not optimizing some expressions fully.
7027336 
DeadCodeElimination was missing optimizaiton opportunities because
it did not account correctly for the methods it had to be run on.

In particular when a constructor body gets optimized away there are new
optimization opportunities in places where it is invoked.

Now DeadCodeElimination is run not only on modified methods but also
on their callers.

Bug: gwtproject#9387
Bug-Link: gwtproject#9387
Change-Id: I1abbee03ce420ae5a29f2bb6fa829c8eb94dff87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rluble rluble

Labels
None yet
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
2 participants
@gkdn @rluble