New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: Add Java 17 language support #9869

Open

6 of 9 tasks

niloc132 opened this issue Dec 6, 2023 · 3 comments

Milestone

Contributor

niloc132 commented Dec 6, 2023 •

edited

This will be one of the leading features for GWT 2.12 - we've experimentally built out more than half of the new features already. The limiting factor is that in order to support a newer JDT, we will need to raising support for running Compiler/DevMode/CodeServer/JUnitShell to Java 11.

Subtasks:

Increase minimum Java to build GWT or run devmode/compiler to 11 #9870
Optional: Explore CI testing for running server classes on Java 8. Will need additional resourcing/testing - this doesn't appear to be a priority for the vast majority of users. An alternative could be to backport fixes to release/2.11 as requested.
Update JDT to support Java 17 language features #9871
Update ErrorProne to support building (and testing) GWT on Java 21 #9859
Add tests for Java 15 text blocks https://openjdk.org/jeps/378
Add tests for Java 17 sealed classes https://openjdk.org/jeps/409
Add compiler implementation, JRE emulation, and tests for Java 16 record types #9894
Add compiler implementation, tests for Java 16 pattern matching instanceof #9893
Add compiler implementation, tests for switch expressions for Java 14 #9878

JRE emulation changes, if any, should be filed in a different task. While reviewing JEPs, I only noticed https://openjdk.org/jeps/356, which may not apply anyway.

niloc132 added this to the 2.12 milestone

Member

jnehlmeier commented Dec 7, 2023

Shouldn't we try to aim 21 directly? Eclipse 2023-12 seems to support it so I guess some JDT should exist?

Contributor Author

niloc132 commented Dec 7, 2023

@jnehlmeier
For the JDT, if already stable, with support for all features, and still supports running on Java 11 I'd agree. Otherwise, I'd personally vote for incrementally building these features and using this issue as a milestone for Java 17, with a follow up milestone (likely for a later release?) for Java 21.

Besides the reasons above, we don't have a lot of PR reviewers anyway, I wouldn't want to say that we can't ship GWT 2.12 until all of 17 and 21 are finished.

vegegoku mentioned this issue

New API emulation from Java version 12 - 17 #9872

Open

6 tasks

Contributor Author

niloc132 commented Dec 17, 2023

Looks like there are just two non-preview language JEPs in 18/19/20/21: https://openjdk.org/jeps/440 and https://openjdk.org/jeps/441. I haven't checked an updated JDT yet, but at least 441 looks like it will need codegen changes.

vegegoku mentioned this issue

Add upgraded JDT and ASM gwtproject/tools#28

Merged

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

3e12be6

Update build scripts to point to the latest JDT [3.36.0.v20231115-1055] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku mentioned this issue

Point to the latest JDT and asm #9884

Closed

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

25e9b91

Update build scripts to point to the latest JDT [3.36.0.v20231115-1055] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

f5e28a1

Update build scripts to point to the latest JDT [3.36.0.v20231115-1055] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

9b37765

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

4db8576

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

f904c46

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

608dc02

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

d6def2e

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

d430a04

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

46dd5c7

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

fbe84b9

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

faa9aaf

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

1cf0047

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

012efff

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix RequestFactorySuite fails under java 21

0abc784

Fix request factory tests fails with errors under java 21 due to added apis to the List class `getLast`, `getFirst`, `isEmpty` which are causing ProxyAutoBean treats the list as a traversable object.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix RequestFactorySuite fails under java 21

39ac7a3

Fix request factory tests fails with errors under java 21 due to added apis to the List class `getLast`, `getFirst`, `isEmpty` which are causing ProxyAutoBean treats the list as a traversable object.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

9f3d577

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

f0a754f

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

5b61a45

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

3aa51cb

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

niloc132 mentioned this issue

Update ErrorProne to run on Java 21, drop Java 8 support #9899

Merged

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

509a916

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

72efdfa

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

3323f66

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

9c9b874

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku mentioned this issue

Update JDT and asm for Java 17 language support #9911

Merged

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

e49b5ab

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

cfdf4b1

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

b564f59

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

371736f

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

3ed3919

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

a99f35f

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

697e337

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Point to the latest JDT and asm

bbb1e56

Update build scripts to point to the latest compatible JDT [3.32.0.v20221108-1853]/[4.26] and the latest asm 9.6

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

36ca133

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Fix fork CI tools reference

f507790

Point CI to the forked tools repository that has java 17 support changes.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add js compile tests

144a08e

Write tests to confirm the code compiles to javascript too, add a test to guard for using records until support is added.

fix gwtproject#9871
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

8cf8a3e

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku mentioned this issue

Add support for instanceof pattern matching feature #9917

Merged

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

aea3f89

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

8d1c2ff

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

7cf7fb1

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

d2ad877

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

999c1bf

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

edebb95

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

e37cc2f

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

zbynek mentioned this issue

Compile error - GWT Google Web Toolkit (2.10.0, 2.10.1, 2.11.0) on java17. #9929

Closed

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

1a6cfb6

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

niloc132 mentioned this issue

Please remove protobuf pom from gwt-servlet #9752

Open

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

d88bf24

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

5baf2f7

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

vegegoku added a commit to vegegoku/gwt that referenced this issue


          Add compiler implementation, tests for Java 16 pattern matching insta…

87b44fd

…nceof

JEP : https://openjdk.org/jeps/394
fix gwtproject#9893
related to gwtproject#9869

niloc132 pushed a commit that referenced this issue


          Add support for instanceof pattern matching feature (#9917)

0074a65

Add compiler implementation, tests for Java 16 pattern matching
instanceof.

JEP https://openjdk.org/jeps/394
Fixes #9893
related to #9869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment