-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed set- and clearTimeout to make debugging working with Firefox #9800
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is based on the patch that @niloc132 provided in the issue as a workaround with a comment
I don't think this is a reasonable fix to make to GWT itself, but it does look like we could remove the watchdog entirely, or only conditionally enable it.
so I think it would be better implement that instead.
|
Sorry for the delay on this. I finally simplified the bug report and filed it at https://bugzilla.mozilla.org/show_bug.cgi?id=1833637. The watchdog timer isn't needed at all to see invalid behavior. Unfortunately, this shows that this patch doesn't go far enough - not only can the watchdog timer keep running, but any other timer can too - we have to fix any other call to |
The same problem occurs in automated tests using selenium with the latest htmlunit-driver. |
That's interesting - did you file an issue with them showing the issue? From the linked issue above, the underlying issue originally intended to be fixed by this patch is a regression in the FF debugger, with a workaround: In |
I use the workaround in SDBG to avoid this problem. |
This fixes a problem that only occurs in firefox while debugging.
Without the fix SDBG Users would be forced to super-source the Impl class.
After a few weeks of testing i did'nt find any negative effects on runtime, or in other browsers.
Has been discussed in #9787.
Fixes #9787