Disable/fix some tests on Windows #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbroyer
reviewed
Mar 25, 2023
| public void testIgnoresHiddenDirectories() throws IOException { | ||
| // Setup a /tmp/.svn/ShouldNotBeFound.java folder structure. | ||
| File tempDir = Files.createTempDir(); | ||
| File nestedHiddenDir = new File(tempDir, ".svn"); | ||
| nestedHiddenDir.mkdir(); | ||
| File javaFile = new File(nestedHiddenDir, "ShouldNotBeFound.java"); | ||
| javaFile.createNewFile(); | ||
| // windows needs the hidden attribute to be set on file (not parent directory) | ||
| java.nio.file.Files.setAttribute(javaFile.toPath(), "dos:hidden", Boolean.TRUE); |
There was a problem hiding this comment.
How about using Files.getFileAttributeView(javaFile.toPath(), DosFileAttributeView.class) and if it's non-null then call setHidden(true)?
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Tests for ResourceAccumulator. | ||
| */ | ||
| public class ResourceAccumulatorTest extends TestCase { | ||
|
|
||
| private final static boolean IS_WINDOWS = System.getProperty("os.name") |
There was a problem hiding this comment.
Do we have commons-lang3 in the classpath? We could use SystemUtils.IS_OS_WINDOWS then.
|
There are two new style warnings, could you fix those? |
tbroyer
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables tests that fail on Windows because of filesystem specifics, fixes one test.