Changes to support Python 3 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshipley
commented
Apr 18, 2014
jshipley
commented
- use str instead of unicode for py3
- use dict.items instead of dict.iteritems for py3
BaseQuery.paginate() method works now.
- use str instead of unicode for py3 - use dict.items instead of dict.iteritems for py3
|
This will fix issue #19 |
…shAlchemy Conflicts: flask_whooshalchemy.py
…hemy Conflicts: flask_whooshalchemy.py
This reverts commit 8366e37.
- One test case fails intermittently - Teardown fails on Windows (whoosh keeps index files open)
|
you can directly override the unicode variable on python 3, minimizing code changes If it's python 3, unicode = str |
|
Any update on when a Python 3 version will be available? |
|
Hey @cheevahagadog! I manage a fork of this project that has incorporated the Python 3 support already. I will work soon on merging my fork back into this repo. Until that is accomplished, I would recommend that you check out the fork in case you need Python 3 support right now. |
|
I believe there's a requirements bug with flask-whooshalchemy (0.8) and your fork @dhamaniasad. Both require Flask==0.10.1 and Whoosh==2.6.0, much older packages than should be necessary IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.