-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix prop size to Text component #590
Comments
Hey, @oharaju! How are you? Since you already came with a solution, are you interested in working on this issue? Cheers, |
Hi @caiotracera! I'm fine and you? Yes, I'm interested. I will make the changes and soon I will open the pull request. |
@oharaju everything is fine 😁 Okay, so we will be waiting for your pull request. But don't need to rush, the next deploy will probably occur only next week. |
Hey Guys!
Using Yoga in my personal project, I noticed a problem regarding the
<Text>
component.In the documentation of the Text props I verified that to change the
![image](https://user-images.githubusercontent.com/93061504/209584296-dd992419-958b-4974-aa51-690f10ddbf55.png)
font-size
it is necessary to use thesize
, however when declaring it I verified that the prop does not work very well.The
Text
component has compatibility with the Yoga System as described in the documentation "Text component also has support for system props as you can see here", this means that, using the typography resources, it enters into duplicity with regard to the properties to change thefont-size
.Props:
size
- only available in the component;fontSize
- available on the Yoga System.When testing using
![image](https://user-images.githubusercontent.com/93061504/209584690-7d6ef515-879d-4c10-a146-f87c65cb05b2.png)
fontSize
instead ofsize
it worked perfectly, below is evidence:Conclusion:
The
size
property has been deprecated by Yoga System (typography), properties but the documentation has not been updated. Just as thevariant
prop is deprecated bycolor
, thesize
prop should also be deprecated byfontSize
.Proposal:
The text was updated successfully, but these errors were encountered: