Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 fix(components): adjust subtitle accordion position #584

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

matheushdsbr
Copy link
Collaborator

JIRA Issue

Adjust subtitle accordion position 馃搫

The position of the subtitle was in the center, I adjusted it to be on the start position.

Platforms 馃摬

  • Web
  • Mobile

Type of change 馃攳

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 馃И

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 馃攳

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 馃摳

Before After
Screen Shot 2022-12-06 at 18 18 30 Screen Shot 2022-12-06 at 18 18 42

Copy link
Contributor

@caioalexandrebr caioalexandrebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃殌

@guilhermecardoso-gympass guilhermecardoso-gympass merged commit c8b5895 into master Dec 7, 2022
@guilhermecardoso-gympass guilhermecardoso-gympass deleted the fix/accordion-subtitle branch December 7, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants