Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[RTN-858] - Fix width and height on Buttons inside Heading component #737

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

agnezi
Copy link
Contributor

@agnezi agnezi commented Feb 22, 2024

JIRA Issue

Description 📄

Fixing the max and min width and height off buttons inside Heading component.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

[Upload your screenshots here]

Before After
Screenshot 2024-02-22 at 13 10 19 Screenshot 2024-02-22 at 13 09 40

@agnezi agnezi marked this pull request as ready for review February 22, 2024 17:36
@agnezi agnezi requested a review from a team February 23, 2024 11:04
@matheushdsbr matheushdsbr merged commit db39d28 into master Feb 23, 2024
3 checks passed
@matheushdsbr matheushdsbr deleted the RTN-858 branch February 23, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants