Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [EUEG-3190 | DS-800] Update PlanCard component to use the correct font-weight #767

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

alycecristines
Copy link
Contributor

JIRA Issue
JIRA Issue

Description 📄

We are updating the PlanCard title component to use the correct new Text style component.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

The update was just on the title prop for PlanCard component

v2 v3 Before v3 After

@ericcleao
Copy link
Member

ericcleao commented Mar 20, 2024

@alycecristines, it would be probably a good moment to also update the component used for the description as Text.Small will soon be removed in future Yoga versions. Currently, Text.Small matches the Text.Body2 design.
Additionally, if it is as simple as the web component I suggest that the native component should match the fix to ensure both designs.
WDYT?

@leonardo-gympass
Copy link
Contributor

Hello @ericcleao, I'm going to answer here since today @alycecristines is on a day off.
We will soon deprecate the PlanCard component from Yoga as it has many items specific to our journey and is only used by our team. The change Alyce made was in the only point we used that had inconsistencies after changing the theme to v3.
We haven't maintained this component in native for two years, the web and native versions already have several inconsistencies.

@ericcleao
Copy link
Member

ericcleao commented Mar 20, 2024

That's great to know, @leonardo-gympass. Considering this, we can move on with the PR (and if the Text.Small is removed before the PlanCard, we will need to revisit this flow).

P.S. To the Yoga team @gympass/code-yoga, we should probably think of a better way to document deprecated components (like the PlanCard in the mobile and some legacy Text components), adding this subject here to not forget to mention.

@leonardo-gympass
Copy link
Contributor

@ericcleao If Text.Small is removed in a major version I think we will be able to remove PlanCard along with it, but first we need to move all the PlanCard logic to our journey.

FYI @eduardobreno

@flavia-moraes flavia-moraes merged commit 225be9b into master Mar 21, 2024
3 checks passed
@flavia-moraes flavia-moraes deleted the fix/adjust-plan-card-title-font-weight branch March 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants