fix: clone command in test_trtools.sh testing script
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryarm
changed the title
test_trtools.sh testing scripttest_trtools.sh testing script
LiterallyUniqueLogin
approved these changes
Feb 21, 2024
aryarm
commented
Feb 21, 2024
Co-authored-by: Arya Massarat <23412689+aryarm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a mistake I made in b23fa56 (in PR #202). I forgot to clone into the current directory and only realized when the bioconda test failed in bioconda/bioconda-recipes#45894 (comment). We managed to patch the bioconda recipe, but anyone who tries to run the
test_trtools.shscript after installing TRTools 6.0.0 with pip will still run into an error. This PR fixes that error for the next release of TRTools.Update (2/20): I also added commit 37c75bb to ensure the
test_trtools.shscript can be executed locally in a development installation of TRTools. Of course, this should only be used to test that thetest_trtools.shscript itself is working. It won't actually test TRTools properly because it will use an outdated version of our test and data files.