Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #781 menubar to render styledstrings #784

Merged
merged 7 commits into from
May 30, 2024

Conversation

svfat
Copy link
Contributor

@svfat svfat commented May 29, 2024

Feature #781
Introduces the ability for the menubar to render colours as specified in StyledString

@gyscos
Copy link
Owner

gyscos commented May 29, 2024

Hi, and thanks for the work!

I added a commit to merge main back in this branch (to solve a minor conflict on the examples directory path), and it should be ready to squash-merge.

Thanks again!

@svfat
Copy link
Contributor Author

svfat commented May 29, 2024

@gyscos Thanks! That was a nice one to sort out and get more familiar with the codebase. However, I can't merge it, because it says:
Review required
At least 1 approving review is required by reviewers with write access.

@gyscos gyscos merged commit 03451ae into gyscos:main May 30, 2024
1 check passed
@svfat svfat deleted the feature/781_menubar_to_render_styledstrings branch May 30, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants