fixes #310

gyselroth · Apr 12, 2019 · 334a018 · 334a018
1 parent e89957e
commit 334a018
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,8 @@
 **Maintainer**: Raffael Sahli <sahli@gyselroth.com>\
 **Date**: Fri Apr 12 16:27:31 CEST 2019
 
-* CORE: [FIX] server must not respond with 401 if a connection to an ldap server could not be established #309
+* API: [FIX] server must not respond with 401 if a connection to an ldap server could not be established #309
+* API: [FIX] patching a group name ends in uncaught exception compact() #310
 
 
 ## 2.5.0

diff --git a/src/app/Balloon.App.Api/v2/Groups.php b/src/app/Balloon.App.Api/v2/Groups.php
@@ -132,7 +132,7 @@ public function post(string $name, ?array $member = null, ?string $namespace = n
     /**
      * Change group attributes.
      */
-    public function patch(string $id, ?array $member = null, ?string $namespace = null): Response
+    public function patch(string $id, ?string $name = null, ?array $member = null, ?string $namespace = null): Response
     {
         $attributes = compact('namespace', 'name', 'member');
         $attributes = array_filter($attributes, function ($attribute) {return !is_null($attribute); });