Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14 #15

Closed
wants to merge 2 commits into from
Closed

Fix #14 #15

wants to merge 2 commits into from

Conversation

blaggacao
Copy link
Collaborator

No description provided.

@blaggacao blaggacao mentioned this pull request Apr 7, 2021
Copy link
Owner

@gytis-ivaskevicius gytis-ivaskevicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was put in place to avoid overwriting nixosConfigurations. Now that I look at it - all extra arguments that are passed to the function probably should be overwritten on top of already built flake (if that makes sense). This would fix this issue and result in cleaner implementation.

This particular patch is rejected.

@blaggacao
Copy link
Collaborator Author

Your suggestion sound good to me, so that would mean nixosConfigurations would go into ..., did I understand you correctly?

@blaggacao
Copy link
Collaborator Author

blaggacao commented Apr 7, 2021

I just have noticed so, that this would need a recursive update. So we'd have to copy them over from lib.

@gytis-ivaskevicius
Copy link
Owner

This is so very annoying since that's quite a bit of code duplication. I Will look into it, maybe ill find some sane solution with good old //. Also, this kinda makes me wonder - maybe this project is too complex not to depend on nixpkgs

Closing this PR since this patch is not going to get merged anyways.

@blaggacao
Copy link
Collaborator Author

maybe this project is too complex not to depend on nixpkgs

I think this restriction should not be dropped before discussing extensively with zimbatm. I think he has stories to tell. I'm looking if we can piggy-back on the selectedSystem somehow (or even just a default x64 selected system).

But in the end, the cleanest solution would probably to copy library function in-tree.

In the end, this is an upstream design issue with how stdlib and pkgs.lib relate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants