imp: provide per channel modules paths to make it easy to "backport" #42
Conversation
blaggacao
force-pushed
the
da/add-per-channel-specia-arg
branch
2 times, most recently
from
719848b
to
361e2fe
Compare
There was a problem hiding this comment.
I like this, it just adds more information to make backporting/updating modules possible.
I think this should go inside configurationBuilder instead and possibly under the optionalAttrs (output == "nixosConfigurations"). It is a default, so its not terrible to put in evalHostArgs, but also its nixos specific and theres another place where modulesPath is edited, so it makes sense to go there.
systemFlake.nix
Outdated
| f = channelName: | ||
| { "${channelName}ModulesPath" = "${channels.${channelName}.input}/nixos/modules"; }; | ||
| channelModulesPath = map f (attrNames channels); | ||
| merge = lhs: rhs: lhs // rhs; |
There was a problem hiding this comment.
I don't think there is much of a point for this merge function :D
blaggacao
force-pushed
the
da/add-per-channel-specia-arg
branch
3 times, most recently
from
816d7d3
to
0d243e3
Compare
blaggacao
force-pushed
the
da/add-per-channel-specia-arg
branch
from
0d243e3
to
e7ae270
Compare
a module. imports = [ ${myChannelModulesPathk}/installer/...
Signed-off-by: David Arnold <dar@xoe.solutions>
blaggacao
force-pushed
the
da/add-per-channel-specia-arg
branch
2 times, most recently
from
ac61a93
to
cbc521b
Compare
blaggacao
force-pushed
the
da/add-per-channel-specia-arg
branch
from
cbc521b
to
a5246e7
Compare
| @@ -149,9 +159,9 @@ let | |||
| ]; | |||
| }) | |||
| ] ++ host.modules; | |||
| specialArgs = host.specialArgs; | |||
| inherit specialArgs; | |||
There was a problem hiding this comment.
this was in failure mode before. we have to remain careful about the builder generalization.
There was a problem hiding this comment.
There was actually a reason for this: setting modulesPath on a non-nixos builder to a nixos path would break things.
I'll address this in #44
There was a problem hiding this comment.
Ok thanks! We have to be really careful about rhose kind of things. There are now +- 5 design dimenstion in 3 lines of code.
There was a problem hiding this comment.
Maybe we'd need to split them eventually apart completely and implement a generic builder and a specific nixos one on top.
a module. imports = [ ${myChannelModulesPathk}/installer/...
This allows users to relatively conveniently pull in modules from other channels. The chances of success are mixed depending on the channel distance, but if it works, it's great.