Return initialization of EBook_CHM :: m_lookupTablesValid #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The load function calls guessTextEncoding before attempting to update the m_chmTOPICS, m_chmSTRINGS, m_chmURLTBL, and m_chmURLSTR objects. Thus, at the time guessTextEncoding is called, these objects and the m_lookupTablesValid flag contain an invalid value. However, guessTextEncoding can (via changeFileEncoding) implicitly call fillTopicsUrlMap, which uses these objects and a flag. In some cases, the combination of object parameters causes the application to crash due to lack of memory.
|
Thank you for your report and the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loadfunction callsguessTextEncodingbefore attempting to update them_chmTOPICS,m_chmSTRINGS,m_chmURLTBLandm_chmURLSTRobjects. Thus, at the timeguessTextEncodingis called, these objects and them_lookupTablesValidflag contain an invalid value. However,guessTextEncodingcan (viachangeFileEncoding) implicitly callfillTopicsUrlMap, which uses these objects and a flag. In some cases, the combination of object parameters causes the application to crash due to lack of memory.There were similar changes in fe6c414, but they got lost in the refactoring in 2bab405 and were permanently removed in f613164.