Fix memoization #105

gyund · 2023-05-29T04:30:50Z

Closes #100

…cached properly without addresses affecting hashing

src/stocktracer/analysis/annual_reports.py

src/stocktracer/analysis/diluted_eps.py

src/stocktracer/collector/sec.py

src/stocktracer/filter.py

gyund added 3 commits May 28, 2023 20:14

create a test to replicate the scenario needing caching

1f678fa

simplify sec by removing one level of classes

c646add

format

576d708

gyund added the bug Something isn't working label May 29, 2023

gyund added 6 commits May 29, 2023 08:49

Merge branch 'main' into gyund/issue100

4c51666

separate filter and results into separate classes so things could be …

3798773

…cached properly without addresses affecting hashing

fix network tests

929c716

fix docs to make sure network tests get rerun

f42f230

remove expiry cache since cache gets evicted when the file changes

36e4dc5

fix lint issues

0efa033

gyund marked this pull request as ready for review May 29, 2023 18:49

github-advanced-security bot found potential problems May 29, 2023

View reviewed changes

src/stocktracer/analysis/annual_reports.py Fixed Show fixed Hide fixed

src/stocktracer/analysis/diluted_eps.py Fixed Show fixed Hide fixed

gyund added 5 commits May 29, 2023 16:25

sort pipfile

b9b52d2

ignore unused argument which is actually used

bd0f447

fix some doc warnings

3058ef8

make ReportDate immutable

cf28dd6

remove import duplication

35a1d1b

gyund commented May 29, 2023

View reviewed changes

gyund added 2 commits May 29, 2023 16:54

fix naming

e1367b2

fix tests

502a6f0

gyund merged commit 1130176 into main May 29, 2023
8 checks passed

gyund deleted the gyund/issue100 branch May 29, 2023 22:15

Provide feedback