add QEMU + other common values as hypervisor type #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Yes looks like this will be a major release, that's fine and we can write them. Maybe we should include the others in the link too while we're at it? |
phip1611
force-pushed
the
add-qemu-as-hypervisor-type
branch
from
922724b
to
be76eb2
Compare
|
I added all of them but can't verify each single one by live-testing. I found all IDs also in the original source code on Github or could verify them in other Github projects too. The only strange thing is that other projects use What do you think? |
phip1611
changed the title
gz
approved these changes
Jul 7, 2021
|
lgtm thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds QEMU as hypervisor type. QEMU is the hypervisor type, if QEMU is used without KVM as accelerator.
PS: Third-party dependents [0] of this lib implemented this manually. I think it would be smart to upstream some of this into this crate.