Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes, refactor names #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

beansandmash
Copy link

** merge redundant pk logic into update by pk args and resolver
** fixed issue with delete by pk if row doesn't exist
** fixed issue with update by pk not committing
** fixed issue with update and update by pk if set_/inc_ is not defined
** fixed error generating schema if table does not have an int/float
** refactor names

@codecov-io
Copy link

codecov-io commented Apr 15, 2021

Codecov Report

Merging #9 (ce9fc56) into master (580e80d) will increase coverage by 32.88%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   27.82%   60.71%   +32.88%     
===========================================
  Files          11       11               
  Lines         442      420       -22     
===========================================
+ Hits          123      255      +132     
+ Misses        319      165      -154     
Impacted Files Coverage Δ
src/graphql_sqlalchemy/dialects/pg/inputs.py 0.00% <0.00%> (ø)
src/graphql_sqlalchemy/resolvers.py 25.30% <11.11%> (+10.75%) ⬆️
src/graphql_sqlalchemy/inputs.py 88.46% <47.05%> (+66.38%) ⬆️
src/graphql_sqlalchemy/names.py 88.23% <83.33%> (+37.17%) ⬆️
src/graphql_sqlalchemy/args.py 100.00% <100.00%> (+51.72%) ⬆️
src/graphql_sqlalchemy/helpers.py 100.00% <100.00%> (+30.00%) ⬆️
src/graphql_sqlalchemy/objects.py 85.71% <100.00%> (+50.00%) ⬆️
src/graphql_sqlalchemy/schema.py 100.00% <100.00%> (+72.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580e80d...ce9fc56. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #9 (50af0b5) into master (54a30d0) will increase coverage by 32.78%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   27.92%   60.71%   +32.78%     
===========================================
  Files          11       11               
  Lines         444      420       -24     
===========================================
+ Hits          124      255      +131     
+ Misses        320      165      -155     
Impacted Files Coverage Δ
src/graphql_sqlalchemy/dialects/pg/inputs.py 0.00% <0.00%> (ø)
src/graphql_sqlalchemy/resolvers.py 25.30% <11.11%> (+10.75%) ⬆️
src/graphql_sqlalchemy/inputs.py 88.46% <47.05%> (+66.38%) ⬆️
src/graphql_sqlalchemy/names.py 88.23% <83.33%> (+37.21%) ⬆️
src/graphql_sqlalchemy/args.py 100.00% <100.00%> (+51.72%) ⬆️
src/graphql_sqlalchemy/helpers.py 100.00% <100.00%> (+30.00%) ⬆️
src/graphql_sqlalchemy/objects.py 85.71% <100.00%> (+50.00%) ⬆️
src/graphql_sqlalchemy/schema.py 100.00% <100.00%> (+72.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a30d0...50af0b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants