New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish low-level record / link patterns #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… referenced fields
…ommitment base anchor (seems a nicer pattern)
…ts via satisfaction
…onse typecasting out of cross-zome callbacks
…nt has agency for managing these links (for now)
…complex relationships easier to construct in future
This was referenced Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch feels like it's stabilising and ready for feedback, there are some cleanup jobs I want to log but will do that separately. This PR:
observation.main
toobservation.economic_event
.planning
DNA. Movesplanning.main
toplanning.commitment
and addsplanning.intent
.lib/hdk_graph_helpers/src/record_helpers.rs
lib/hdk_graph_helpers/src/record_interface.rs
lib/hdk_graph_helpers/src/link_helpers.rs
This will close #18, #19, #20 & #23. #21 can probably be closed and ignored in lieu of finishing all fields for the main flow record types as its logic is no longer any different to #20. Will log the larger job separately when I transcribe my cleanup notes.
AFAIK more or less the only remaining cleanup to get to a nice pattern for the rest of the system is the record macros in #22, which as you can see when you look at
intent.rs
,commitment.rs
&economic_event.rs
is simply a case of wrapping the commonalities between those 3 files up.Does not yet, but needs to: