Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Summary as fallback for description #508

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

schnerring
Copy link
Contributor

When the .Description of a page is not set, it's good practice useful to fallback to the Hugo-generated .Summary value. See also: https://gohugo.io/variables/page/

I have added the fallback to the flexsearch descriptions and description meta tag. I briefly looked at other places where .Description is used:

  • layouts/_default/index.js
  • layouts/_default/index.json

However, I can't say if it makes sense to also add a fallback there, as well.

Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-enk h-enk merged commit 6a7df65 into gethyas:master Oct 14, 2021
@schnerring schnerring deleted the flexsearch-description branch October 14, 2021 20:36
adhadse pushed a commit to adhadse/doks that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants