🐛 fix for h-omer#8 #13
Conversation
…ading of large data sets, bug fixes
|
Hi! And thanks for your contribution! May I ask you if you could also provide some tests for what you've implemented? Thanks! |
|
sure, I will work on those next week, thanks! |
|
Thank you so much! |
|
test added, please let me know if you want additional testing |
| if (listA.size() != listB.size()) { | ||
| System.out.println("Lists must have same size" + listA); | ||
| } else { | ||
| for (int index = 0; index < listA.size(); index++) { |
There was a problem hiding this comment.
return IntStream.range(0, listaA.size())
.mapToObj(i -> Pair.of(listA.get(i), listB.get(i))
.collect(Collectors.toList());
| @@ -222,7 +221,20 @@ public static LocalDateTime convertEpochToLocalDateTime(Long epochDateTime) { | |||
| return Instant.ofEpochMilli(epochDateTime).atZone(ZoneId.systemDefault()).toLocalDateTime(); | |||
| } | |||
|
|
|||
| public static Boolean isSystemType(String type) { | |||
| public static <A, B> List<org.apache.commons.lang3.tuple.Pair<A, B>> zip(List<A> listA, List<B> listB) { | |||
| List<Pair<A, B>> pairList = new LinkedList<>(); | |||
There was a problem hiding this comment.
Remove in favor of following comment
| isEntityOrThrowException(entitySource); | ||
|
|
||
| return entityDestinations.size() == relProps.size() ? sourceCurrentState.map(node -> zip(entityDestinations, relProps).stream().map((item) -> { | ||
| final Node destinationNode = item.getLeft(); |
There was a problem hiding this comment.
Is it possible to move this inlined function into a more speaking method of the same class?
| Optional<Node> sourceCurrentState = createNewSourceState(entitySource, defaultToNow(date)); | ||
| isEntityOrThrowException(entitySource); | ||
|
|
||
| return entityDestinations.size() == relProps.size() ? sourceCurrentState.map(node -> zip(entityDestinations, relProps).stream().map((item) -> { |
There was a problem hiding this comment.
Is it possible to use explicit "if" condition? It is more readable.
✨ multiple relationship delete
|
Hi @tschn , can you please explain the new procedure you've added for multiple relationship delete? |
|
@tschn is there any chance you're going to explain your changes? we would like to integrate those, but it would be nice to hear something from you! |
|
please see latest commit for updated documentation, the plural procedures were added to allow updating more than one relationship for a given state for 'batch' style updates to the graph |
check to see if relationship end node matches before deleting