New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commonのリファクタ #8

Merged

h-sugawara merged 2 commits into release/v1.1.0 from feature/refactor-common

Nov 22, 2023

Owner

h-sugawara commented Nov 22, 2023

Description

Remove all string operate methods form common.
Create some methods which string operate at strings.
Refactor a common test.
Add a strings test.
Add getValidNumber method at common.
Refactor all methods of opengraph.

Relations

Nothing

References

issues of common.js @ codeclimate

Others

Nothing

h-sugawara added 2 commits

November 22, 2023 20:57


          Commonから文字列操作に関するメソッドを分離

8d03124


          OpenGraphのリファクタ

53bf49b

h-sugawara merged commit b4cbcad into release/v1.1.0

2 checks passed

h-sugawara deleted the feature/refactor-common branch

November 22, 2023 12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment