forked from rapid7/metasploit-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/collab/18351 #25
Merged
Merged
Pr/collab/18351 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Python deserialization gadget that will exec arbitrary Python code in place. It is only compatible with Python 3.x due to differences in Python's exec function and statement between 2 and 3.
Check for and raise a more specific error message when the internal database fails to mount because the path is incorrect.
8 tasks
h00die
reviewed
Oct 11, 2023
@@ -520,7 +502,7 @@ def rce_implant | |||
'uri' => normalize_uri(target_uri.path, 'superset', 'dashboard', 'p', permalink_key, '/') | |||
) | |||
# we go through some permalink hell here | |||
until res.headers['Location'].nil? | |||
until res.nil? || res.headers['Location'].nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
@@ -273,6 +273,7 @@ def mount_internal_database | |||
) | |||
|
|||
fail_with(Failure::Unreachable, "#{peer} - Could not connect to web service - no response") if res.nil? | |||
fail_with(Failure::UnexpectedReply, "#{peer} - Failed to mount the internal database: #{datastore['DATABASE']}") if res.code == 422 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think I tested for this. Good to know it gives a super easy HTTP code to distinguish from!
Worked for me.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes:
DATABASE
option is incorrect.res
is nil because the payload is running.add_equals_to_base64
function to be private by just defining it inline.