Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-module): splitted to modules #42

Merged
merged 17 commits into from
Jun 23, 2024
Merged

feat(multi-module): splitted to modules #42

merged 17 commits into from
Jun 23, 2024

Conversation

l3r8yJ
Copy link
Collaborator

@l3r8yJ l3r8yJ commented Jun 14, 2024

ref: #13
ref: #26

@h1alexbel take a look, please


PR-Codex overview

This PR updates the Cargo workflows, adds Clap for argument parsing, and refactors code structure.

Detailed summary

  • Updated Cargo workflows for Clippy and formatting checks
  • Added Clap for argument parsing in the CLI
  • Refactored code structure in main.rs and args.rs
  • Updated licensing information in Cargo.toml files

The following files were skipped due to too many changes: server/src/lib.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel h1alexbel self-requested a review June 14, 2024 11:24
Copy link
Owner

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ take a look, please. BTW, maybe let's name module like that: fakehub-cli, fakehub-server, wdyt?

@@ -0,0 +1,24 @@
[package]
name = "fakehub"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be server in order to be built by cargo

@l3r8yJ
Copy link
Collaborator Author

l3r8yJ commented Jun 14, 2024

@h1alexbel does it make any sense to have fakehub- prefix inside of fakehub workspace? Don't get it, can you explain?

@h1alexbel
Copy link
Owner

@l3r8yJ let's drop the prefix then

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.33%. Comparing base (73a71f9) to head (2c673fa).

Files Patch % Lines
cli/src/main.rs 0.00% 2 Missing ⚠️
server/src/lib.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #42       +/-   ##
===========================================
+ Coverage   22.58%   53.33%   +30.75%     
===========================================
  Files           3        4        +1     
  Lines          31       15       -16     
===========================================
+ Hits            7        8        +1     
+ Misses         24        7       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l3r8yJ
Copy link
Collaborator Author

l3r8yJ commented Jun 15, 2024

@h1alexbel take a look, please

@l3r8yJ l3r8yJ requested a review from h1alexbel June 15, 2024 01:58
Copy link
Owner

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ take a look, please

Cargo.toml Show resolved Hide resolved
Copy link
Owner

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server/src/lib.rs Show resolved Hide resolved
@h1alexbel
Copy link
Owner

@l3r8yJ let's stay with default clippy configuration for now

cli/Cargo.toml Outdated Show resolved Hide resolved
@l3r8yJ
Copy link
Collaborator Author

l3r8yJ commented Jun 22, 2024

@h1alexbel in general PR is ready and you can review it, but I have small problem with build. While i'm trying to find WA, i've posted a question on SO, hope someone will answer sooner than I'll fix it by myself

@l3r8yJ l3r8yJ requested a review from h1alexbel June 22, 2024 17:25
@l3r8yJ
Copy link
Collaborator Author

l3r8yJ commented Jun 23, 2024

@h1alexbel take a look, please

@h1alexbel h1alexbel merged commit f8bde4e into master Jun 23, 2024
16 of 17 checks passed
@h1alexbel h1alexbel deleted the 13 branch June 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants