Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create our test case for pre_filter.py #32

Merged
merged 2 commits into from Apr 18, 2024
Merged

chore: create our test case for pre_filter.py #32

merged 2 commits into from Apr 18, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Apr 18, 2024

PR-Codex overview

This PR introduces improvements to the TestPreFilter class in test_pre_filter.py. It enhances directory handling and adds tests for directory creation and output file generation.

Detailed summary

  • Introduced DIR constant for directory name
  • Updated directory handling in setUp and tearDown methods
  • Added test for creating the pipeline directory
  • Added test for creating the output file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 18, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit afa27ee into master Apr 18, 2024
7 checks passed
@rultor
Copy link
Collaborator

rultor commented Apr 18, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 7min)

@h1alexbel h1alexbel deleted the 30 branch April 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants