-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove __init__.py
as they are no longer necessary.
#112
Conversation
I think we just need to delete empty |
I think for ease of management and consistency, let’s *require* only one
consistent way of referencing modules and that is through the full path.
Allowing shortcuts would invite sloppiness.
—
Algorithms of the Mind
Christopher Nguyen
Co-Founder & CEO
A I T O M A T I C, Inc.
linkedin.com/in/ctnguyen
…On Fri, Jan 7, 2022, 9:56 PM Nhan Vu ***@***.***> wrote:
I think we just need to delete empty __init__.py files which are needed
by Python 2. The __init__.py files are also used to expose sub-modules,
classes to avoid long/awkward import statements, for example from
h1st.model.repository import ModelRepository instead of from
h1st.model.repository.model_repository import ModelRepository and
common/initialization code/documentation for that sub-module. So we should
only delete __init__.py files with unnecessary code/documentation.
—
Reply to this email directly, view it on GitHub
<#112 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRIIAZJCK7AV2G2NBYOY3UU7GZPANCNFSM5LQGKFGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
OK. Then could you help update the import statement in |
👍
—
Algorithms of the Mind
Christopher Nguyen
Co-Founder & CEO
A I T O M A T I C, Inc.
linkedin.com/in/ctnguyen
…On Sat, Jan 8, 2022, 12:27 PM Nhan Vu ***@***.***> wrote:
OK. Then could you help update the import statement in
h1st/core/context.py too. Currently it is from h1st.model.repository
import ModelRepository.
—
Reply to this email directly, view it on GitHub
<#112 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRIIAD3TVC4WW72ONIFKTUVCMZLANCNFSM5LQGKFGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
of the file, rather than inline, for easier maintenance.
"All checks have passed." 😎 Please merge and close out #111 @nhanitvn @Shiti cc @TheVinhLuong102 |
See #111