refactor: Add Modeler classes for Oracles #137
Conversation
nhanitvn
commented
Mar 4, 2022
•
nhanitvn
commented
- Add Modeler classes
- Refactor code to build/train Oracles
- Use H1st Predictive Model for ensembling Students and Teacher's output instead of the general H1st StackEnsemble
- Test cases passed
| self.stats = {} | ||
|
|
||
| def generate_features(self, data: Dict): | ||
| @classmethod |
There was a problem hiding this comment.
@nhanitvn Did you use @classmethod here because you need to use this method in OracleModeler without instantiating Oracle class ? I am not sure if this is the best option. Have you thought about using @staticmethod ?
There was a problem hiding this comment.
I don't know any benefit of using @classmethod if it is not factory method.
There was a problem hiding this comment.
The benefit is that you can override generate_features() in Oracle's subclasses and have the overridden one called instead :)
| @@ -127,25 +119,22 @@ def predict(self, input_data: Dict) -> Dict: | |||
| raise RuntimeError('No student built') | |||
|
|
|||
| # Generate features to get students' predictions | |||
| predict_data = self.generate_data(input_data) | |||
| predict_data = self.__class__.generate_data(input_data, self.teacher, self.stats) | |||
There was a problem hiding this comment.
If we make generate_data a staticmethod, then this will look more beautiful.
There was a problem hiding this comment.
This looks ugly here. However, the classmethod benefit the build_model(). Check TimeseriesOracleModeler and you see that we don't need to re-implement build_model(). With static method, you cannot do so.
