Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model metrics and stats to Model class #188

Merged
merged 7 commits into from Mar 1, 2023
Merged

Conversation

phamhoangtuan
Copy link
Contributor

Pull Request Checklist

Before sending your pull requests, make sure you followed this list.

Checklist for Pull Request

  • Describe what this PR purpose. For example, for new features describe what problem this PR solves. If there is JIRA task, please include JIRA link.
  • When there are more than one tasks in the PR, use to do list in github mark down.
  • Include unit tests. If small test files are needed for your unit tests, please include them as well. Be conservative in adding test files, try to make them small and local instead of putting it on S3 or external database.
  • Assign reviewer.

Running unit tests

Using tools and libraries installed directly on your system.
For example, to run all tests under graphengine, do:

nose2

@phamhoangtuan phamhoangtuan added the bug Something isn't working label Feb 27, 2023
@phamhoangtuan phamhoangtuan self-assigned this Feb 27, 2023
@hiro-v hiro-v merged commit f14a4ac into main Mar 1, 2023
Copy link
Contributor

@hiro-v hiro-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phamhoangtuan phamhoangtuan deleted the fix/add_model_metrics branch March 2, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants