First Serializable implementation to support remoting of h1.Model over the wire #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. to support remoting of Models over the wire. The main problem occurs when we pre-instantiate Keras models within h1.Models, and the latter has to be serialized for parallel execution. The contained Keras models do not serialize properly, and exceptions are thrown at the remote side as a result.
nqbao
reviewed
Aug 24, 2020
| words = full_class_name.split(".") | ||
| module_name = ".".join(words[:-1]) | ||
| class_name = words[-1:][0] | ||
| the_class = getattr(sys.modules[module_name], class_name) |
There was a problem hiding this comment.
It is safer to use importlib to retrieve the module. we can also move this to util
thangtp
previously approved these changes
Aug 24, 2020
thangtp
reviewed
Aug 24, 2020
This was referenced Aug 30, 2020
|
On hold. See milestone info. |
ghost
added
the
Devansh2005
approved these changes
May 6, 2021
|
This was being done to integrate training using Ray. This code is out of sync and a separate PR should be created with the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. we still have to make sure the offending (Keras) models are deleted prior to serialization, so that they don't cause exception on the other side.