Fix MP4 matcher #30
Merged
Fix MP4 matcher #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Apparently, there are a few redundant |
|
Ops, fixed. |
|
This does not seem to work correctly due to the case-sensitivity. |
Closed
|
I've found this site which lists all known "ftyp"s, and it seems to have the correct case, for MSNV it is upper case indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With information from http://www.file-recovery.com/mp4-signature-format.htm.
I tested on many MP4 files I have here, all were detected.
I redid the implementation in a way that makes it easier to add more 4-byte codes, as it seems there are many of them.
See if this way is ok with your, or you prefer it done the way it were before.