-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ms ooxml #48
support ms ooxml #48
Conversation
1c8a5f9
to
9f401df
Compare
This looks promising. Can you add some test and real file fixtures? |
OK, i just add 3 files, and modified MatchReader buffer size from 512 to 4096 to make test pass but, 4096 bytes may not be enough for real files, according to file(1) magic for Microsoft Office XML |
Thanks. Let's see if the CI build passes and we can merge things. |
…96 bytes maybe not enough
b975e69
to
a98cd2a
Compare
be9f4bc
to
9914f38
Compare
i just don't know why travis would fail, local test is ok |
i see, this is an import path problem, if i change import path in code from seems v1 will use cc14fdc |
0bfe170
to
2db4035
Compare
Gotcha. Today I think using |
so, maybe this PR is OK now? |
code comes from : file msooxml magic rule
Matchers is a map, and map iteration order is random, so maybe zip rule will be matched before msooxml rules, so i just simply add an array, to keep the same order as func
register
doesand, msooxml rules share the same check code, but i don't know how to merge them into one type, because type and checker seems to be binded when calling
register