Fixed normal retry time.sleep to use interval #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2non
reviewed
Dec 29, 2016
| @@ -157,19 +159,25 @@ def _handle_error(self, err): | |||
| # Update latest cached error | |||
| self.error = err | |||
|
|
|||
| # Did user interrupt function? | |||
| if err is KeyboardInterrupt or err is ImportError: | |||
| raise | |||
There was a problem hiding this comment.
Thanks for this, but I'm going to support this in a more versatile way where the developer can add/mutate the error exceptions whitelist.
|
LGTM, however I'm going to introduce some changes there in order to support some features. |
h2non
reviewed
Dec 29, 2016
| self.on_retry(err, delay) | ||
|
|
||
| # Sleep before next try | ||
| self.sleep(0.5) |
There was a problem hiding this comment.
Good catch! I don't know how I forgot about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed inconsistent test: #7
Also added ImportError and KeyboardInterrupt to be raised despite retry: #6