Emit warning (instead of fatal error) when failing to set TCP Fast Open #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
changed the title
kazuho
added a commit
that referenced
this pull request
Jun 19, 2015
…cp-fastopen Emit warning (instead of fatal error) when failing to set TCP Fast Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #356 we have added support for TCP Fast Open which is enabled by default (if
TCP_FASTOPENis defined in the header files).However, people may use the server complied in an environment with
TCP_FASTOPENdefined, and use the binary in an environment (i.e. kernel) that does not support the feature (see the comments on the pull-req). In such situation, the server fails to boot up due to the fact that it exits with a fatal error ifsetsockopt(TCP_FASTOPEN)fails.This PR changes how the error is being handled. Instead of refusing to start, the server now just emits a warning and continues to operate if
setsockopt(TCP_FASTOPEN)fails.