Some cleanups #25
Merged
Some cleanups #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this as WIP because it has not yet tested enough, but it is OK to review and comment on changes of course! 😃 |
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Even OpenSSL >= 1.1.0 may be built without EC APIs due to footprint or patent problems, and LibreSSL >= 2.9.1 provides the EC APIs while it may not contain some of newer RSA APIs. Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
It is possible that macros with OPENSSL_ prefix will collide with OpenSSL's usage. The NEVERBLEED_ prefix will not for sure. Also, descriptive names will prevent from reusing them in inappropriate ways, like OPENSSL_1_1_API has been used for two different purpose: 1) to check if RSA_METHOD is opaque and 2) to check if the new unified EC APIs are available. Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
OPENSSL_NO_EC is also lacked in pre-EC-era OpenSSL, not only LibreSSL. Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
|
Now it is (mostly) ready! Just I am too lazy to bring up a CentOS box for testing... |
|
Built successfully with CentOS 7. |
kazuho
approved these changes
Aug 20, 2019
|
Thank you for your prompt review, @kazuho! Tested on CentOS 7 using
Since proposed changes affect significantly to OpenSSL without EC support (as it failed to build |
|
Thank you very much for all your efforts, and the matrix of tests that you have covered. |
This was referenced Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides trivial "add one blank line here for consistency" and "the ordering seems dirty a bit" ones, this PR does the following:
NEVERBLEED_prefix for feature detection macros to avoid future collisions.#includesI believe these changes will improve maintainability and compatibility with LibreSSL. However, the branch is constructed on a step-by-step basis, so please feel free to point out inappropriate ones. I am ready to exclude them.
Compiles with:
RSA_shim unneeded)RSA_shim unneeded)RSA_shim unneeded)RSA_shim needed)RSA_shim unneeded)RSA_shim unneeded)RSA_shim needed)Fixes #19