Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert when combining session resume and HRR in QUIC #122

Closed
huitema opened this issue Mar 2, 2018 · 4 comments
Closed

Assert when combining session resume and HRR in QUIC #122

huitema opened this issue Mar 2, 2018 · 4 comments

Comments

@huitema
Copy link
Collaborator

huitema commented Mar 2, 2018

During the QUIC trial, I observed something strange. Several server allow testing the "stateless retry" function of QUIC. For TLS, that means:

       Client Hello -->
              <-- HRR (with Cookie)
       Client Hello with selected handshake and cookie -->
              <-- Server Hello, etc.

The strangeness happens when the client owns a Resume Ticket. We get:

       Client Hello  + Resume Ticket -->
              <-- HRR (with Cookie)
       Try to process HRR in client (ptls_handshake)
       Assert in "derive_exporter_secret(tls, is_early=1)", complains that *slot is NULL.

I ended up mitigating this with the following hack: set the "ticket" in handshake properties to "NULL" before calling ptls_handshake with the received HRR message.

@kazuho
Copy link
Member

kazuho commented Mar 7, 2018

Do you see the issue after #119 being merged? #119 was opened and merged the same day.

@huitema
Copy link
Collaborator Author

huitema commented Mar 7, 2018

I have to undo my mitigation in order to test...

@huitema
Copy link
Collaborator Author

huitema commented Mar 7, 2018

Just did this test after removing the mitigation on the client. The connection worked fine:

  1. Sent CH with "zero key shares" + session ticket;
  2. Sent 0-RTT packet;
  3. Received Stateless Retry (HRR)
  4. Repeated CIient Initial (Client Hello)
  5. Received Handshake packet with Server Hello, etc.

We are good, you can close the issue.

@kazuho
Copy link
Member

kazuho commented Mar 7, 2018

I'm glad to hear that. Thank you for checking!

@kazuho kazuho closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants