Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Unknown Frame wrongly returned error code #524

Closed
bathooman opened this issue Aug 15, 2022 · 2 comments
Closed

BUG: Unknown Frame wrongly returned error code #524

bathooman opened this issue Aug 15, 2022 · 2 comments

Comments

@bathooman
Copy link

Description

  • Type: Non-conformance Bug
  • Priority: Minor

Non-conformance Bug

Commit: 482610b

**Expected behavior **
The QUIC 1 RFC in section 12.4 states that:

An endpoint MUST treat the receipt of a frame of unknown type as a connection error of type FRAME_ENCODING_ERROR.

**Actual behavior **

When a client and a server are exchanging packets, receipt of an unknown frame will cause the generation of a CC with the PROTOCOL_VIOLATION error code.

I have attached the captured interaction between a QUIC client and a server containing the mentioned problem. The master secret log file is also attached so that one can decrypt the exchanged traffic.

unknown-frame-type.zip

@kazuho
Copy link
Member

kazuho commented Aug 15, 2022

Thank you for reporting the issue.

I think the behavior is correct, we do support frame type 0x30 (DATAGRAM), and the draft states that PROTOCOL_VIOLATION MUST be sent when support for the DATAGRAM frame has not been indicated by the peer (https://datatracker.ietf.org/doc/html/draft-ietf-quic-datagram#section-3).

@bathooman
Copy link
Author

You are right about this. I assume we can close this issue then.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants