Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against spontaneous wakeups during forks #2438

Closed
st-pasha opened this issue May 14, 2020 · 0 comments · Fixed by #2495
Closed

Protect against spontaneous wakeups during forks #2438

st-pasha opened this issue May 14, 2020 · 0 comments · Fixed by #2495
Assignees
@st-pasha
Labels
improve Improvement of an existing functionality
Projects
Sprint Jun 15 - Jul 5
Milestone
Release 0.11.0

Comments

@st-pasha
Copy link
Contributor

Currently we ensure that all threads are sleeping when a fork occurs. However, there is still a small probability that a sleeping thread may be spontaneously woken up by the system at any moment. If this occurs during a fork, something bad may (theoretically) happen. In order to avoid such possibility we should probably physically shut down all threads prior to forking.
@st-pasha st-pasha added the improve Improvement of an existing functionality label May 14, 2020
@st-pasha st-pasha added this to the Release 0.11.0 milestone May 14, 2020
@st-pasha st-pasha self-assigned this May 14, 2020
@st-pasha st-pasha added this to To Do in Sprint May 4-24 May 14, 2020
@st-pasha st-pasha added this to To Do in Sprint May 25 - Jun 14 via automation May 27, 2020
@st-pasha st-pasha moved this from To Do to In Progress in Sprint May 4-24 May 27, 2020
@st-pasha st-pasha moved this from In Progress to To Do in Sprint May 4-24 May 27, 2020
@st-pasha st-pasha removed this from To Do in Sprint May 4-24 May 27, 2020
@st-pasha st-pasha removed this from To Do in Sprint May 25 - Jun 14 Jun 17, 2020
@st-pasha st-pasha mentioned this issue Jun 26, 2020
Merged
Sprint Jun 15 - Jul 5 automation moved this from To do to Done Jun 27, 2020
st-pasha added a commit that referenced this issue Jun 27, 2020
@st-pasha
Shut down threads during forking (#2495)
49c5def 
The fork handler was changed so that now all threads are stopped and joined before the fork.

Closes #2438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
improve Improvement of an existing functionality
Projects
No open projects
Sprint Jun 15 - Jul 5
  
Done
Milestone
Release 0.11.0
Development

Successfully merging a pull request may close this issue.

Shut down threads during forking h2oai/datatable
1 participant
@st-pasha