Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CategoricalColumn_Impl and support for basic operations #3158

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Implement CategoricalColumn_Impl and support for basic operations #3158

merged 5 commits into from
Sep 8, 2021

Conversation

oleksiyskononenko
Copy link
Contributor

@oleksiyskononenko oleksiyskononenko commented Sep 4, 2021 •
edited
Loading

  • implemented CategoricalColumn_Impl;
  • added support for categorical columns in dt.Frame();
  • added support for categorical columns in a terminal, also allowing the element access through [i, j] selector;
  • added and modified some relevant tests.

WIP for #1691

@oleksiyskononenko oleksiyskononenko added test Add new tests, or fix existing tests new feature Feature requests for new functionality labels Sep 4, 2021
@oleksiyskononenko oleksiyskononenko added this to the Release 1.1.0 milestone Sep 4, 2021
@oleksiyskononenko oleksiyskononenko self-assigned this Sep 4, 2021
@oleksiyskononenko
Copy link
Contributor Author

I have added a task in #1691 to think through and implement effective N/A handling for categoricals. Merging this PR as it seems that there are no other issues here.

@oleksiyskononenko oleksiyskononenko changed the title Implement categorical columns Implement CategoricalColumn_Impl and support for basic operations Sep 8, 2021
@oleksiyskononenko oleksiyskononenko merged commit 95662d0 into main Sep 8, 2021
@oleksiyskononenko oleksiyskononenko deleted the ok/cat-impl branch September 8, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st-pasha st-pasha st-pasha left review comments

Assignees

@oleksiyskononenko oleksiyskononenko

Labels
new feature Feature requests for new functionality test Add new tests, or fix existing tests
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleksiyskononenko @st-pasha