Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search functionality for sphinx 4.* #3316

Merged
merged 3 commits into from Jul 20, 2022
Merged

Conversation

oleksiyskononenko
Copy link
Contributor

@oleksiyskononenko oleksiyskononenko commented Jul 20, 2022

Adjust our custom theme in a way similar to sphinx_rtd_theme, see readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx 4.*. We can take care of sphinx 5.*, that was recently released later, if needed.

Closes #3299

@oleksiyskononenko oleksiyskononenko added this to the Release 1.1.0 milestone Jul 20, 2022
@oleksiyskononenko oleksiyskononenko self-assigned this Jul 20, 2022
@oleksiyskononenko oleksiyskononenko changed the title Fix search functionality with new sphinx Fix search functionality with the new sphinx versions Jul 20, 2022
@oleksiyskononenko oleksiyskononenko changed the title Fix search functionality with the new sphinx versions Fix search functionality for sphinx 4.* Jul 20, 2022
@oleksiyskononenko oleksiyskononenko merged commit 3664f0f into main Jul 20, 2022
@oleksiyskononenko oleksiyskononenko deleted the ok/docs-fix-search branch July 20, 2022 23:42
samukweku pushed a commit that referenced this pull request Aug 4, 2022
Adjust our custom theme in a way similar to `sphinx_rtd_theme`, see  readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx `4.*`. We can take care of sphinx `5.*`, that was recently released later, if needed.

Closes #3299
samukweku pushed a commit that referenced this pull request Aug 10, 2022
Adjust our custom theme in a way similar to `sphinx_rtd_theme`, see  readthedocs/sphinx_rtd_theme#1021. This fixes the search functionality for sphinx `4.*`. We can take care of sphinx `5.*`, that was recently released later, if needed.

Closes #3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation FIX Fix for an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken search functionality in documentation
1 participant