Add basic support for Grouping::GtoFEW
#3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksiyskononenko
changed the title
Grouping::GtoFEWGrouping::GtoFEW
samukweku
approved these changes
Oct 15, 2022
|
Merging, error is not relevant to this PR. |
samukweku
pushed a commit
that referenced
this pull request
Jan 3, 2023
It seems that `dt.categories()` is the first datatable function, that needs to produce `Grouping::GtoFEW` columns. That's because the number of categories in a categorical column could be anything between `0` and `nrows - 1`. Currently, datatable doesn't really support `Grouping::GtoFEW`, but may need it for the cases when `dt.categories()` is combined with other f-expressions, or when `dt.categories()` is applied to columns that have different number of underlying categories. In this PR we - add some basic support for `Grouping::GtoFEW` grouping mode; - adjust `dt.categories()` to produce `Grouping::GtoFEW` columns, that in the case of uneven number of rows are promoted to `Grouping::GtoALL`; - do minor refactoring in `dt.alias()` function. WIP for #1691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
dt.categories()is the first datatable function, that needs to produceGrouping::GtoFEWcolumns. That's because the number of categories in a categorical column could be anything between0andnrows - 1. Currently, datatable doesn't really supportGrouping::GtoFEW, but may need it for the cases whendt.categories()is combined with other f-expressions, or whendt.categories()is applied to columns that have different number of underlying categories.In this PR we
Grouping::GtoFEWgrouping mode;dt.categories()to produceGrouping::GtoFEWcolumns, that in the case of uneven number of rows are promoted toGrouping::GtoALL;dt.alias()function.WIP for #1691