Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpliftDRF fix UpliftDRF MOJO Python/R API, add documentation about supporting MOJO, add tests #15832

Closed
maurever opened this issue Oct 17, 2023 · 0 comments
Closed

UpliftDRF fix UpliftDRF MOJO Python/R API, add documentation about supporting MOJO, add tests #15832

maurever opened this issue Oct 17, 2023 · 0 comments
Assignees
@maurever
Labels
bug
Milestone
3.44.0.2

Comments

@maurever
Copy link
Contributor

maurever commented Oct 17, 2023 •
edited

The UpliftDRF MOJO has broken Python and R API. We are not able to predict with MOJO. The predict method throws java.lang.IllegalArgumentException: Unsupported MOJO model 'upliftdrf'.

mojo_model = h2o.upload_mojo(model_path)
prediction_reloaded = mojo_model.predict(train_h2o)

Also, the uplift metrics are not present in the MOJO.

Also, the docs say UpliftDRF does not support MOJO:
https://docs.h2o.ai/h2o/latest-stable/h2o-docs/data-science/upliftdrf.html#custom-metric-example-for-uplift-drf
@maurever maurever added the bug label Oct 17, 2023
@maurever maurever self-assigned this Oct 17, 2023
@maurever maurever added this to the 3.44.0.2 milestone Oct 17, 2023
@maurever maurever changed the title UpliftDRF fix documentation about supporting MOJO UpliftDRF fix documentation about supporting MOJO, add tests Oct 17, 2023
@maurever maurever changed the title UpliftDRF fix documentation about supporting MOJO, add tests UpliftDRF fix UpliftDRF MOJO Python/R API, add documentation about supporting MOJO, add tests Oct 17, 2023
@maurever maurever mentioned this issue Oct 17, 2023
Merged
3 tasks
mn-mikke added a commit that referenced this issue Oct 18, 2023
@mn-mikke
[GH-15832] Add "Known Bug" section to release notes
bed22c3
mn-mikke added a commit that referenced this issue Oct 18, 2023
@mn-mikke @hannah-tillman
[GH-15842] Add "Known Bug" section to release notes (#15843)
d34ab36 
* [GH-15832] Add "Known Bug" section to release notes

* Use singular form

* ht/broke it up

made it so "known bug" and the note explaining what this new section is aren't on the same line

---------

Co-authored-by: Hannah Tillman <hannah.tillman@h2o.ai>
@mn-mikke mn-mikke mentioned this issue Oct 18, 2023
Merged
mn-mikke added a commit that referenced this issue Oct 18, 2023
@mn-mikke @hannah-tillman
[GH-15832] Add "Known Bug" section to release notes (#15847)
cb8f68b 
* [GH-15832] Add "Known Bug" section to release notes

* Use singular form

* ht/broke it up

made it so "known bug" and the note explaining what this new section is aren't on the same line

---------

Co-authored-by: Hannah Tillman <hannah.tillman@h2o.ai>
maurever added a commit that referenced this issue Nov 1, 2023
@maurever
GH-15832 Fix UpliftDRF MOJO API, add docs, tests (#15838)
c9e1ff2 
* Fix Uplift MOJO API, add tests

* Add tests, fix predict

* Implement Generic logic behind Python/R uplift MOJO API
@maurever maurever closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurever maurever

Labels
bug
Projects
None yet
Milestone
3.44.0.2
Development

No branches or pull requests
1 participant
@maurever