You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to review plot functions, ensure they all use the same parameter frame and to keep backwards compatibility, we can alias or deprecate the data param.
For consistency between Py and R API, it is also preferrable to apply similar changes in R.
The text was updated successfully, but these errors were encountered:
…cy (#15895)
* replaced partial_plot function param 'data' with 'frame', and kept the old param as deprecated
* also renamed param in R for consistency with other R plot functions
* in R, ensure the deprecated args are checked first
* fix dots parameter handling in partialPlot
* fix R doc on partialPlot
* fix R doc on partialPlot
* revert partialPlot handling of dots param using list() as ...names is available only since 4.1.0
* missed a data renamed to newdata
* rename varargs to dots for clarity
Issue reported by https://support.h2o.ai/a/tickets/106739
Users may use reflection to generate plots, in which case it is much preferable to use consistent naming in plot functions parameters.
User noted that the
data
param in Py functionis inconsistent with other plot functions, for example:
We need to review plot functions, ensure they all use the same parameter
frame
and to keep backwards compatibility, we can alias or deprecate thedata
param.For consistency between Py and R API, it is also preferrable to apply similar changes in R.
The text was updated successfully, but these errors were encountered: