Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the functions that are supposed to be exported are exported in the R package #15894

Closed
tomasfryda opened this issue Oct 31, 2023 · 0 comments
Closed

Make sure the functions that are supposed to be exported are exported in the R package #15894

tomasfryda opened this issue Oct 31, 2023 · 0 comments
Assignees
@tomasfryda
Labels
bug
Milestone
3.44.0.3

Comments

@tomasfryda
Copy link
Contributor

tomasfryda commented Oct 31, 2023 •
edited

This issue should now cover all unexported R functions that were meant to be exported.

Originally, this was only about h2o.result not being exported in the R package while it should have been.

R model selection example that uses h2o.result is not working as h2o.result is not exported. A workaround is to use h2o:::h2o.result instead.
@tomasfryda tomasfryda added the bug label Oct 31, 2023
@tomasfryda tomasfryda self-assigned this Oct 31, 2023
@tomasfryda tomasfryda added this to the 3.44.0.3 milestone Oct 31, 2023
@tomasfryda tomasfryda changed the title h2o.result is not exported in the R package Make sure the functions that are supposed to be exported are exported in the R package Nov 2, 2023
@tomasfryda tomasfryda mentioned this issue Nov 2, 2023
Merged
tomasfryda added a commit that referenced this issue Nov 10, 2023
@tomasfryda
GH-15894: Make sure the functions that are supposed to be exported ar…
437e432 
…e exported in the R package (#15899)

* use devtools import into tests only the exported functions/methods

* Import more internal functions for tests

* Remove non-existent target_encode functions from the _pkgdown.yml

* Export extractAIC for CoxPH and add more internal functions

* Export median.H2OFrame

* Fix stats::median for H2OFrame

* Improve docs and docstrings

* Remove h2o.logIt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasfryda tomasfryda

Labels
bug
Projects
None yet
Milestone
3.44.0.3
Development

No branches or pull requests
1 participant
@tomasfryda