Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perRow metric calculation #16074

Closed
maurever opened this issue Feb 16, 2024 · 0 comments
Closed

Improve perRow metric calculation #16074

maurever opened this issue Feb 16, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@maurever
Copy link
Contributor

  1. I found these changes very inefficient:

boolean score4Generic = m != null && m.getClass().toString().contains("Generic");

6421a81

We should implement something like the method isGeneric() instead of comparing the name of the class with the hardwired String.

  1. I also find this condition in ModelMetricBinomial is not usefull anymore:

double err = iact + 1 < ds.length ? 1 - ds[iact + 1] : 1; // Error: distance from predicting ycls as 1.0

Because iact + 1 is always lower than ds.length for binomial cases.

@maurever maurever self-assigned this Feb 16, 2024
@maurever maurever added this to the 3.46.0.1 milestone Feb 22, 2024
maurever added a commit that referenced this issue Feb 23, 2024
* Improve perRow calculation

* Fix model null case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant