Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gave warning if GAM bs=2 (I-spline/monotone spline) but parameter non_negative is not set to TRUE. #16116

Closed
wendycwong opened this issue Mar 8, 2024 · 0 comments
Closed

Gave warning if GAM bs=2 (I-spline/monotone spline) but parameter non_negative is not set to TRUE. #16116

wendycwong opened this issue Mar 8, 2024 · 0 comments
Assignees
@wendycwong
Labels
feature
Milestone
3.46.0.2

Comments

@wendycwong
Copy link
Contributor

wendycwong commented Mar 8, 2024 •
edited

Current implementation of GAM will just run to completion when a user wants monotonicity splines but fail to choose non_negative=TRUE. As a result, their model output will complete but does not have monotonicity. Instead of throwing an error, I will just set non_negative =TRUE for the user.
@wendycwong wendycwong self-assigned this Mar 8, 2024
wendycwong pushed a commit that referenced this issue Mar 8, 2024
GH-16116: throw error if user specified monotone spline but failed to…
709ba9d 
… choose solver=irlsm.
@wendycwong wendycwong mentioned this issue Mar 8, 2024
Merged
@wendycwong wendycwong changed the title Force GAM to throw error if solver != IRLSM when monotonicity is desired Gave warning if GAM bs=2 (I-spline/monotone spline) but parameter non_negative is not set to TRUE. Mar 16, 2024
wendycwong pushed a commit that referenced this issue Mar 16, 2024
GH-16116: add warning message to users if they only choose monotone s…
c8f0c3a 
…plines (bs=2) but did not set non_negative=true. They will not be getting monotone output in this case.
wendycwong pushed a commit that referenced this issue Mar 16, 2024
GH-16116: add warning message to users if they only choose monotone s…
4f9da67 
…plines (bs=2) but did not set non_negative=true. They will not be getting monotone output in this case.
wendycwong pushed a commit that referenced this issue Mar 19, 2024
GH-16116: add warning message to users if they only choose monotone s…
c38bc26 
…plines (bs=2) but did not set non_negative=true. They will not be getting monotone output in this case.
@wendycwong wendycwong added this to the 3.46.0.2 milestone Mar 20, 2024
wendycwong added a commit that referenced this issue Mar 25, 2024
@wendycwong
GH-16116: add warning if user choose monotone splines but did not set…
43ff7b3 
… non_negative=true (#16121)

* GH-16116: add warning message to users if they only choose monotone splines (bs=2) but did not set non_negative=true.  They will not be getting monotone output in this case.

Co-authored-by: wendycwong <wendy.wong@h2o.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendycwong wendycwong

Labels
feature
Projects
None yet
Milestone
3.46.0.2
Development

No branches or pull requests
1 participant
@wendycwong