-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModelSelection MaxRSweep replacement bug #6961
Comments
Wendy Wong commented: It looks like the replacement step in H2O-3 modelselection maxrsweep stops too early: !image-20220707-174319.png|width=50%! The replacement step should use replace C101 with C89 with an increase of R2. |
Wendy Wong commented: The issue here is this: After forward step, say I have selected ABC as my predictors. Then, I go into the replacement step and aiming to try out _BC where I will pick the subcarrier in first position. Say, I chose DBC as the best. The next replacement should be D_C where I will pick the subcarrier in the middle position. However, I implemented it wrong and was starting with A_C. I fixed this and compared my result with customer result and they match. |
JIRA Issue Details Jira Issue: PUBDEV-8758 |
Attachments From Jira Attachment Name: image-20220707-174319.png |
Linked PRs from JIRA |
No description provided.
The text was updated successfully, but these errors were encountered: