Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelSelection MaxRSweep replacement bug #6961

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments
Closed

ModelSelection MaxRSweep replacement bug #6961

exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments
Assignees

Comments

@exalate-issue-sync
Copy link

No description provided.

@exalate-issue-sync
Copy link
Author

Wendy Wong commented: It looks like the replacement step in H2O-3 modelselection maxrsweep stops too early:

!image-20220707-174319.png|width=50%!

The replacement step should use replace C101 with C89 with an increase of R2.

@exalate-issue-sync
Copy link
Author

Wendy Wong commented: The issue here is this:

After forward step, say I have selected ABC as my predictors.

Then, I go into the replacement step and aiming to try out _BC where I will pick the subcarrier in first position. Say, I chose DBC as the best.

The next replacement should be D_C where I will pick the subcarrier in the middle position. However, I implemented it wrong and was starting with A_C. I fixed this and compared my result with customer result and they match.

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8758
Assignee: Wendy Wong
Reporter: Wendy Wong
State: Resolved
Fix Version: 3.38.0.1
Attachments: Available (Count: 1)
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Attachments From Jira

Attachment Name: image-20220707-174319.png
Attached By: Wendy Wong
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8758/image-20220707-174319.png

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6246
https://github.com/h2oai/h2oai-serving/pull/1079

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants