Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inherits() vs class() in R package to pass new CRAN checks #7038

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Closed

Use inherits() vs class() in R package to pass new CRAN checks #7038

exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Assignees

Comments

@exalate-issue-sync
Copy link

{quote}Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers
 Maintainer: 'Erin LeDell <[erin@h2o.ai|mailto:erin@h2o.ai]>'

Flavor: r-devel-windows-x86_64
Check: installed package size, Result: NOTE
   installed size is 181.1Mb
   sub-directories of 1Mb or more:
     R       1.4Mb
     java  178.3Mb

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: R code for possible problems, Result: NOTE
 Found if() conditions comparing class() to string:
 File 'h2o/R/communication.R': if (class(rawResponse) == "try-error") ...
 File 'h2o/R/explain.R': if (class(object) == "list") ...
 File 'h2o/R/kvstore.R': if (class(model) == "H2OAutoML") ...
 File 'h2o/R/kvstore.R': if (class(model) == "H2OAutoML") ...
 File 'h2o/R/models.R': if (class(node) == "H2OLeafNode") ...
 Use inherits() (or maybe is()) instead.{quote}

@exalate-issue-sync
Copy link
Author

Michal Kurka commented: 1 PR merged, another to follow - [https://github.com//pull/6136#issuecomment-1092299759|https://github.com//pull/6136#issuecomment-1092299759]

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8649
Assignee: Erin LeDell
Reporter: Erin LeDell
State: Resolved
Fix Version: 3.36.1.1
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6136

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants